[Selection Input] Refactor auto-complete system. #27389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
requested review from
bengotow,
hellendag,
benpankow and
clairelin135
and removed request for
bengotow,
hellendag,
benpankow and
clairelin135
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit d889556. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/selection/__tests__/SelectionAutoComplete.test.ts
Dismissed
Show dismissed
Hide dismissed
salazarm
changed the base branch from
master
to
salazarm/filter-out-kind-tags
salazarm
requested review from
alangenfeld,
bengotow,
benpankow and
clairelin135
salazarm
force-pushed
the
salazarm/refactor-auto-complete-logic
branch
from
794d7e3 to
b8b7551
Compare
bengotow
approved these changes
Feb 3, 2025
...-ui/packages/ui-core/src/asset-selection/input/useAssetSelectionAutoCompleteProvider.oss.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-selection/input/util.ts
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-selection/input/util.ts
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-selection/input/util.ts
Outdated
Show resolved
Hide resolved
...odules/dagster-ui/packages/ui-core/src/pipelines/useOpGraphSelectionAutoCompleteProvider.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/selection/SelectionAutoCompleteProvider.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/selection/SelectionInputAutoCompleteResults.tsx
Show resolved
Hide resolved
LoHertel
pushed a commit
to LoHertel/dagster
that referenced
this pull request
Feb 11, 2025
## Summary & Motivation
The primary goal of this refactor is to decouple the auto-complete
suggestion UI from the autocomplete visitor logic.
Before:
- Visitor hard coded the types of the suggestions
- UI rendering was tightly coupled to those types
- The types were too restrictive, they required all of the values to be
strings but that doesn't work well for tags which have a key and a
value. Encoding the tags as a string (eg: `"key"="value"`) created
ambiguities, where we could not tell if the string was a tag of `{key:
"key", value: "value"}` or a tag of `{key: "key"="value", value:
undefined}`.
After:
- Rendering is encapsulated in the SelectionAutoCompleteProvider which
is also responsible for making auto-complete suggestions and can handle
both string and tag object types.
## How I Tested These Changes
Existing jest test in SelectionAutocomplete.ts. + Manual testing in
cloud and OSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The primary goal of this refactor is to decouple the auto-complete suggestion UI from the autocomplete visitor logic.
Before:
"key"="value") created ambiguities, where we could not tell if the string was a tag of{key: "key", value: "value"}or a tag of{key: "key"="value", value: undefined}.After:
How I Tested These Changes
Existing jest test in SelectionAutocomplete.ts. + Manual testing in cloud and OSS.